support pickle to graphite #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metrics. Looking ahead to supporting the graphite pickle format.
|
awesome, thanks so much for re-submitting this! |
|
Glad to. It ended up being less work than I feared (what made me gun-shy last year). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the graphite pickle wire protocol.
There are two new configuration options related to graphite:
If
graphiteProtocolis configured as pickle then thegraphitePicklePortis used instead of the currentgraphitePortconfiguration. BothgraphitePicklePortandgraphitePortnow default to their well-known values, making them optional.The limited implementation of the Python pickle format required for Graphite support is documented in
graphite_pickle.md.The tests in
graphite_pickle_tests.jsinvoke a Python script to verify that the packets received over the wire are able to be interpreted. This means that a Python interpreter is expected to be in the path.Replaces #312.