support pickle to graphite. #312
Conversation
metrics. Looking ahead to supporting the graphite pickle format.
|
Any possibility of this being merged? |
|
+1 to getting this merged. Sending in metric line format is overwhelming my carbon-relay daemons! |
|
++, yeah, would be really sweet to have 😄 |
|
Hey sorry it took me so long to get back to you on this. I totally dropped the ball on this. Could you rebase this on the newest master? I'll merge it then. Awesome contribution, thank you so much for this! |
|
It's a shame to see this fruit wither in a branch. |
|
@aronatkins do you have time to update this for the current master branch? |
|
@mrtazz I'll try and make time. Unfortunately, it's basically a rewrite. Maybe its best to close this PR until that can happen (in the spirit of "spring cleaning" 😁 ). |
|
#528 is the same work ported to a new branch based off current master. Closing this PR as obsolete. |
|
When I use pickle, every flush metrics, logs |
Add support for the graphite pickle wire protocol.
There are two new configuration options related to graphite:
If
graphiteProtocolis configured aspicklethen thegraphitePicklePortis used instead of the currentgraphitePortconfiguration. BothgraphitePicklePortandgraphitePortnow default to their well-known values, making them optional.The limited implementation of the Python pickle format required for Graphite support is documented in
graphite_pickle.md.The tests in
graphite_pickle_tests.jsinvoke a Python script to verify that the packets received over the wire are able to be interpreted. This means that a Python interpreter is expected to be in the path. We are open to discussing alternate testing options.