chore(blockifier_reexecution): add blockifier_reexecution to commitlint #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aner-starkware
force-pushed
the
aner/add_blockifier_reexecution_to_commitlint
branch
from
bee4411 to
f61333b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
- Coverage 74.18% 64.66% -9.53%
==========================================
Files 359 134 -225
Lines 36240 14529 -21711
Branches 36240 14529 -21711
==========================================
- Hits 26886 9395 -17491
+ Misses 7220 4706 -2514
+ Partials 2134 428 -1706
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aner-starkware
requested review from
dorimedini-starkware and
AvivYossef-starkware
dorimedini-starkware
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
aner-starkware
deleted the
aner/add_blockifier_reexecution_to_commitlint
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is