Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #391 #392

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Fix #391 #392

merged 1 commit into from
Feb 18, 2024

Conversation

peasoft
Copy link
Contributor

@peasoft peasoft commented Feb 18, 2024

Before my fix

requestPages = {0, ...}
// 1 not in requestPages, unshift(1)
requestPages = {1, 0, ...}

After my fix

requestPages = {0, ...}
// 1 not in requestPages, requestPages[0] = 1
requestPages = {1, ...}

d-bytebase
d-bytebase approved these changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@d-bytebase d-bytebase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@d-bytebase d-bytebase merged commit 6b82f2c into star-history:main Feb 18, 2024
tianzhou added a commit that referenced this pull request Mar 10, 2024
@tianzhou
fix: backport #392
28ac2ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-bytebase d-bytebase d-bytebase approved these changes

@boojack boojack Awaiting requested review from boojack boojack is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peasoft @d-bytebase