VHELM update #2592
Merged
VHELM update #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanmai
requested changes
Apr 26, 2024
src/helm/clients/vision_language/huggingface_vision2seq_client.py
Outdated
Show resolved
Hide resolved
yifanmai
approved these changes
May 1, 2024
|
|
||
| - name: huggingface/llava-v1.6-vicuna-7b-hf | ||
| model_name: uw-madison/llava-v1.6-vicuna-7b-hf | ||
| tokenizer_name: hf-internal-testing/llama-tokenizer |
There was a problem hiding this comment.
Use the respective tokenizers (vicuna etc)?
There was a problem hiding this comment.
I think vicuna uses the llama tokenizer if I'm not mistaken.
|
|
||
| return {"predictions": [{"text": raw_response.candidates[0].text}]} | ||
| if not candidates: |
There was a problem hiding this comment.
We should make this condition tighter... I'll send you a follow-up pull request to fix it.
|
|
||
| _models_lock: Lock = Lock() | ||
| _models: Dict[str, Optional[Vision2SeqModelProcessor]] = { | ||
| "HuggingFaceM4/idefics2-8b": None, |
There was a problem hiding this comment.
Any reason we need to explicitly declare models here? Most clients do not validate which model names are supported (because the list can change frequently).
There was a problem hiding this comment.
It was for name validation. Do you think I can just remove this line then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: