Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tsx type name in pre-commit #1898

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix tsx type name in pre-commit #1898

merged 1 commit into from
Oct 16, 2023

Conversation

yifanmai
Copy link
Collaborator

Fixes this error when running pre-commit:

==> At Hook(id='prettier')
==> At key: types_or
==> At index 0
=====> Type tag 'typescript' is not recognized.  Try upgrading identify and pre-commit?

@farzaank
Copy link
Contributor

farzaank commented Oct 16, 2023 •
edited
Loading

It appears this will resolve the problem [https://pre-commit.com/#filtering-files-with-types]. I'd approve as my branch with Mike introduced this problem, but I'll let Josse review too.

@yifanmai
Copy link
Collaborator Author

Feel free to review @farzaank (you can add yourself as a reviewer).

@yifanmai yifanmai requested a review from farzaank October 16, 2023 21:34
farzaank
farzaank approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@farzaank farzaank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as https://pre-commit.com/#filtering-files-with-types shows this is the recommended way to add TS as a type

@yifanmai
Copy link
Collaborator Author

Thanks @farzaank !

@yifanmai yifanmai merged commit 473acb2 into main Oct 16, 2023
@yifanmai yifanmai deleted the yifanmai/fix-pre-commit-tsx branch October 16, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farzaank farzaank farzaank approved these changes

@JosselinSomervilleRoberts JosselinSomervilleRoberts Awaiting requested review from JosselinSomervilleRoberts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yifanmai @farzaank