Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prettier for formatting #1878

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Add prettier for formatting #1878

merged 5 commits into from
Oct 6, 2023

Conversation

mkly
Copy link
Contributor

@mkly mkly commented Oct 6, 2023

  • Add prettier for formatting
  • Add formatting check to CI

@mkly mkly mentioned this pull request Oct 6, 2023
Closed
@mkly
Add prettier for formatting
6280c06 
* Add prettier for formatting
* Add formatting check to CI
@farzaank farzaank requested review from yifanmai and farzaank October 6, 2023 04:48
@farzaank
Copy link
Contributor

farzaank commented Oct 6, 2023

Looks good to me, but I'll let Yifan decide before merging

yifanmai
yifanmai approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@yifanmai yifanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! (CI breakage is unrelated to this PR.)

@yifanmai yifanmai merged commit 8408c0d into stanford-crfm:main Oct 6, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farzaank farzaank farzaank approved these changes

@yifanmai yifanmai yifanmai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkly @farzaank @yifanmai