-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #193
Merged
Merged
V2 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pcj
commented
Nov 16, 2021
- Large rewrite with gazelle support
* Add c++ client/server example * Elide feature_test
* Migrate builtin_test * Migrate scalapb_test * Migrate grpc_test * Add initial proto_repository.bzl * Vendor bazel-gazelle PR 1033 * YConfig parsing * Update readme
Previously the mappings were not accouting for the case of being run in an external workspace. To fix that, it is necessary to thread in the config.WorkDir property. If we are running in a directory like /.../external/foo, the output mappings become prefixed with "external/foo/..."
This was an experiment within python prior to integration with the rules_python gazelle generator.
* Gazelle apply * Buildfier fixes
This change add a new repository rule that works like go_repository. There is quite a bit of changes around rule resolution and dependency management.
* Initial ts_proto_library * Rewrite with tsc action * Add transitive support * Add proto_ts_library.go * Use genrule script instead of go_binary * Initial proto_ts_library impl * Update example with nestJs/gRPC * Pass args to the tsc compile action * Fix output file naming for protoc-gen-ts-proto * Upgrade bazel-gazelle, add mergemappings test * Migrate mappings (string_dict) -> output_mappings (string_list) * Fix deps resolution for proto_java_library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.