Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve relative paths on link generation #199

Merged

Conversation

moradology
Copy link
Collaborator

This PR addresses a couple of small issues introduced with the recent stac-pydantic 2.0 and model customization updates. First, urljoins now build links preserving relative paths. Second, conformance classes are now on CoreCrudClient and its async variant, enabling users to customize these values when instantiating a client

@lossyrob
Copy link
Member

lossyrob commented Jul 27, 2021

Thanks for catching. Can you add tests to make sure we catch this in the future if it regresses again?

@moradology moradology force-pushed the fix/relative-link-generation branch from ed5d954 to d996f5a Compare August 10, 2021 13:23
@moradology
Copy link
Collaborator Author

moradology commented Aug 10, 2021

I believe this is ready for review once more

Copy link
Collaborator

@geospatial-jeff geospatial-jeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geospatial-jeff geospatial-jeff merged commit 9ef8601 into stac-utils:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants