Fix database hydration #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is in the ordering of arguments to content_hydrate; this shows true failures across other hydrate tests
bitner
approved these changes
May 16, 2022
|
Will merge and release once #114 is merged and integrated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug caused by a misordering of parameters on one of the
content_hydrateoverloads. This surfaced in queries that used database hydration when the base item had assets that did not belong to the target item. Assets were 'added' from the base item that did not have hrefs, therefore causing invalid items to be produced.Added tests that check for a valid item after load, and modified the hydration tests to use
content_hydrateinstead ofmerge_jsonb.Updates to 0.6.3