Avoid updating partitions table when unnecessary #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lossyrob
commented
May 14, 2022
| @@ -137,15 +148,18 @@ def read_json(file: Union[Path, str, Iterator[Any]] = "stdin") -> Iterable: | |||
| yield orjson.loads(line) | |||
|
|
|||
|
|
|||
| @dataclass | |||
There was a problem hiding this comment.
Remove dataclass; this is more appropriate as a normal Python object. IMO dataclasses should have light functionality and really be kept to data containers with public members (sort of like a struct). The dataclass requirement for immutable defaults was forcing the need to make this private attribute optional, which triggered the change from a dataclass to a standard object.
lossyrob
force-pushed
the
feature/rde/partition-insert
branch
from
787fc09 to
ebd4b6d
Compare
lossyrob
commented
May 14, 2022
| geom = Geometry.from_geojson(geojson) | ||
| if geom is None: | ||
| raise Exception(f"Invalid geometry encountered: {geojson}") | ||
| geometry = str(geom.wkb) |
There was a problem hiding this comment.
Check for None to appease type linter
This commit refactors the loader code to avoid unnecessary partition updates. Partition updates should be avoided when unnecessary as they can have a large performance impact for partitions containing many items.
lossyrob
force-pushed
the
feature/rde/partition-insert
branch
from
ebd4b6d to
f4f1e82
Compare
|
Tested this on a re-ingest of Sentinel 1 GRD with about a ~10x improvement in ingest timing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the loader code to avoid unnecessary partition updates. Partition updates should be avoided when unnecessary as they can have a large performance impact for partitions containing many items.