Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable category #15

Merged
merged 3 commits into from
Sep 25, 2020
Merged

Nullable category #15

merged 3 commits into from
Sep 25, 2020

Conversation

stabacco
Copy link
Owner

Not sure why, but category is null for new stocks.

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 25, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.06%.

Quality metrics Before After Change
Complexity 0.00 0.00 0.00
Method Length 71.00 🙂 71.50 🙂 0.50 👎
Working memory 3.00 ⭐ 3.00 ⭐ 0.00
Quality 90.72% 90.66% -0.06% 👎
Other metrics Before After Change
Lines 63 63 0
Changed files Quality Before Quality After Quality Change
stake/equity.py 90.72% ⭐ 90.66% ⭐ -0.06% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@stabacco stabacco merged commit 0959da9 into master Sep 25, 2020
@stabacco stabacco deleted the fix-yearly-return branch October 20, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant