Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run integration tests on alpine:latest #1553

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Run integration tests on alpine:latest #1553

wants to merge 6 commits into from

Conversation

Rob-Hague
Copy link
Collaborator

@Rob-Hague Rob-Hague commented Dec 9, 2024 •
edited
Loading

edit: the integration tests started failing with Alpine Linux 3.21. This tracks setting the image back to alpine:latest after #1554

@Rob-Hague
Copy link
Collaborator Author

Integration tests failing with "Killing sshd.pam service failed with exit code 1" e.g.

  Failed Common_DisposeAfterLossOfNetworkConnectivity [900 ms]
  Error Message:
   Test method Renci.SshNet.IntegrationTests.ConnectivityTests.Common_DisposeAfterLossOfNetworkConnectivity threw exception: 
System.ApplicationException: Killing sshd.pam service failed with exit code 1.


  Stack Trace:
      at Renci.SshNet.IntegrationTests.SshConnectionDisruptor.PauseSshd(SshClient client) in /home/runner/work/SSH.NET/SSH.NET/test/Renci.SshNet.IntegrationTests/SshConnectionDisruptor.cs:line 36
   at Renci.SshNet.IntegrationTests.SshConnectionDisruptor.BreakConnections() in /home/runner/work/SSH.NET/SSH.NET/test/Renci.SshNet.IntegrationTests/SshConnectionDisruptor.cs:line 18
   at Renci.SshNet.IntegrationTests.ConnectivityTests.Common_DisposeAfterLossOfNetworkConnectivity() in /home/runner/work/SSH.NET/SSH.NET/test/Renci.SshNet.IntegrationTests/ConnectivityTests.cs:line 75
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Started between 4Dec and 7Dec. Looks like it is caused by alpine:latest bumping to 3.21. It uses OpenSSH 9.9

@Rob-Hague
Copy link
Collaborator Author

Rob-Hague commented Dec 9, 2024 •
edited
Loading

works with Alpine Linux 3.20 & OpenSSH 9.7

can reproduce locally now (my "alpine:latest" was still at 3.18)

@Rob-Hague Rob-Hague mentioned this pull request Dec 9, 2024
Merged
Rob-Hague
Rob-Hague commented Dec 22, 2024
View reviewed changes
test/Renci.SshNet.IntegrationTests/SshConnectionDisruptor.cs
output = command.Execute();
if (command.ExitStatus != 0)

using (var command = client.CreateCommand("sudo pkill -9 -U sshnet -f sshd-session.pam"))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sshd.pam -> sshd-session.pam is the fix for OpenSSH 9.8+. However, that release also completely removes DSA at compile time, so now the DSA tests fail.

I think it is time to remove DSA

@Rob-Hague Rob-Hague mentioned this pull request Dec 22, 2024
Open
@Rob-Hague Rob-Hague changed the title CI debugging Run integration tests on alpine:latest Dec 22, 2024
mus65
mus65 reviewed Dec 23, 2024
View reviewed changes
test/Renci.SshNet.IntegrationTests/Dockerfile
@@ -1,4 +1,4 @@
FROM alpine:3.20
FROM alpine:latest
Copy link
Contributor

@mus65 mus65 Dec 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't the original issue show that using latest is a bad idea? It made CI suddenly fail without an obvious indication why. Imho it would make more sense to tag it to 3.21.0 (even the patch) and use Dependabot to keep it up-to-date.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first such issue in ~1.5 years of these integration tests. I don't think we necessarily need to make a process out of it, but if it's simple enough to do then sure

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well it was simple enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mus65 mus65 mus65 left review comments

@drieseng drieseng Awaiting requested review from drieseng drieseng will be requested when the pull request is marked ready for review drieseng is a code owner

@WojciechNagorski WojciechNagorski Awaiting requested review from WojciechNagorski WojciechNagorski will be requested when the pull request is marked ready for review WojciechNagorski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rob-Hague @mus65