Upgrade to go go-1.13 #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dpordomingo
force-pushed
the
upgrade-go
branch
from
a342714 to
2d31534
Compare
Closed
se7entyse7en
approved these changes
Sep 16, 2019
|
Reading the release notes, it looks like we need to update |
dpordomingo
force-pushed
the
upgrade-go
branch
from
6130d42 to
7b0988d
Compare
|
good catch @carlosms! |
carlosms
reviewed
Sep 16, 2019
dpordomingo
force-pushed
the
upgrade-go
branch
from
7b0988d to
1f6a6d1
Compare
carlosms
approved these changes
Sep 16, 2019
According to our conventions we should update to last go version Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
In go 1.13, GO111MODULE=auto activates the module-aware mode of the go command when the the current working directory contains, or is below a directory containing go.mod also when in /projects. Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
dpordomingo
force-pushed
the
upgrade-go
branch
from
1f6a6d1 to
40e8686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #198
fix #238
According to our conventions, we should update to last go version