Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the slash property from Path #882

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Conversation

swankjesse
Copy link
Collaborator

This was an attempt to make Paths have a property that would
differentiate whether they follow Windows vs. UNIX rules. But
the consequence as that two relative paths, 'foo', and 'foo'
could be different because of the hidden state of the unused
slash.

Instead just look inside the path for the slash. In the case
where we're resolving two paths without either having any
slash characters internally, just use the platform slash.

This was an attempt to make Paths have a property that would
differentiate whether they follow Windows vs. UNIX rules. But
the consequence as that two relative paths, 'foo', and 'foo'
could be different because of the hidden state of the unused
slash.

Instead just look inside the path for the slash. In the case
where we're resolving two paths without either having any
slash characters internally, just use the platform slash.
@swankjesse swankjesse force-pushed the jwilson.0110.path_slash branch from 5dbe1a4 to 9630b86 Compare January 10, 2021 19:09
@swankjesse swankjesse merged commit cf28008 into master Jan 11, 2021
@swankjesse swankjesse deleted the jwilson.0110.path_slash branch January 11, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants