Add a multiplatform okio.Closeable interface #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
force-pushed
the
jwilson.0105.closeable
branch
2 times, most recently
from
22b50a2 to
a912a81
Compare
Not having it made interacting with Okio particularly annoying
on non-JVM platforms.
Note that we use our own use {} function on all platforms and do
not delegate to Kotlin's use {} function on the JVM. I couldn't
find a way to call Kotlin's use function from our own use function
since they both extend Closeable.
swankjesse
force-pushed
the
jwilson.0105.closeable
branch
from
a912a81 to
cc815b8
Compare
swankjesse
commented
Jan 5, 2021
| @@ -15,12 +15,15 @@ | |||
| */ | |||
| package okio | |||
|
|
|||
| actual interface Sink { | |||
| actual interface Sink : Closeable { | |||
There was a problem hiding this comment.
I ended up having to put Sink back so the JVM one could keep the Flushable interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having it made interacting with Okio particularly annoying
on non-JVM platforms.
Note that we use our own use {} function on all platforms and do
not delegate to Kotlin's use {} function on the JVM. I couldn't
find a way to call Kotlin's use function from our own use function
since they both extend Closeable.