Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the README - this is longer a "new" library #309

Merged
merged 1 commit into from
May 12, 2017
Merged

Update the README - this is longer a "new" library #309

merged 1 commit into from
May 12, 2017

Conversation

SalvatoreT
Copy link
Contributor

@SalvatoreT SalvatoreT commented May 12, 2017 •
edited
Loading

screen shot 2017-05-12 at 11 19 57 am

JakeWharton
JakeWharton reviewed May 12, 2017
View reviewed changes
README.md Outdated
@@ -1,7 +1,9 @@
Okio
====

Okio is a new library that complements `java.io` and `java.nio` to make it much
[![Build Status](https://travis-ci.org/square/okio.svg?branch=master)](https://travis-ci.org/square/okio)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't like these

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially not at the top as it's the least important information in this file

@SalvatoreT
Copy link
Contributor Author

screen shot 2017-05-12 at 11 33 23 am

@swankjesse swankjesse merged commit c0529a9 into square:master May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SalvatoreT @JakeWharton @swankjesse