Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle module name resolution in KSP #947

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

ZacSweers
Copy link
Collaborator

Due to lack of upstream support in KSP + a bug in the K2 analysis API around exposing module names for mangling, we can't properly support non-public APIs in KSP2. This catches those cases and gracefully offers a error message of advice to make it public instead. Previously this would just hard crash at runtime with a ClassNotFoundException

Due to lack of upstream support in KSP + a bug in the K2 analysis API around exposing module names for mangling, we can't properly support non-public APIs in KSP2. This catches those cases and gracefully offers a error message of advice to make it public instead. Previously this would just hard crash at runtime with a ClassNotFoundException
@ZacSweers ZacSweers requested a review from RBusarow April 3, 2024 17:57
@ZacSweers ZacSweers enabled auto-merge (squash) April 5, 2024 17:54
@ZacSweers ZacSweers merged commit 355c1b0 into square:main Apr 5, 2024
17 checks passed
RBusarow pushed a commit that referenced this pull request Apr 9, 2024
* Gracefully handle module name resolution in KSP

Due to lack of upstream support in KSP + a bug in the K2 analysis API around exposing module names for mangling, we can't properly support non-public APIs in KSP2. This catches those cases and gracefully offers a error message of advice to make it public instead. Previously this would just hard crash at runtime with a ClassNotFoundException

* Don't generate if mangled without available mangling

* Update message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants