don't leak Anvil's annotation artifacts to the target project's compile classpath #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBusarow
force-pushed
the
rick/compileOnly-annotations
branch
from
ec9fd64 to
3167ff2
Compare
steve-the-edwards
approved these changes
Jan 2, 2024
RBusarow
force-pushed
the
rick/compileOnly-annotations
branch
2 times, most recently
from
50e232e to
0d3cc7d
Compare
RBusarow
force-pushed
the
rick/compileOnly-annotations
branch
from
0d3cc7d to
81cb9f4
Compare
JoelWilcox
approved these changes
Jan 22, 2024
| * For this test, we're testing what dependencies Anvil adds to the target project's own | ||
| * `runtimeClasspath` and `compileClasspath` configurations. Specifically, it adds the Anvil | ||
| * annotations dependency -- but is it added correctly as a `compileOnly` dependency, | ||
| * or is it being added as `implementation` or something else? |
There was a problem hiding this comment.
Thanks 😄 I think the coffee had just kicked in.
| * or is it being added as `implementation` or something else? | ||
| */ | ||
| @TestFactory | ||
| fun `annotations aren't in the runtime classpath`() = listOf( |
There was a problem hiding this comment.
Nit: Since we also care about verifying that the annotations are included in the compile classpath, something like annotations are only included in the compile classpath might be better for encoding the expectations
There was a problem hiding this comment.
That's an excellent point. Thanks!
RBusarow
force-pushed
the
rick/compileOnly-annotations
branch
from
81cb9f4 to
e6a8d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.