Use references for safety #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| // Save pointer to DB object | ||
| m_db = db; |
There was a problem hiding this comment.
Good catch! 👍 This really looks like a super useless assignment!
|
Looks good. Thanks a lot for having the patience to clean this all up, @innermous 😃 The only cornerstone I could think of is what we would do when we decide to support multiple database connections in one instance. But even then I don't see why we would need to pass around pointers. |
|
@MKleusberg glad to hear that :) |
vtronko
added a commit
that referenced
this pull request
Dec 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this can have cornerstones, so I need fresh POV, @MKleusberg