Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set NULL correctly on Alt-Delete #663

Merged
merged 1 commit into from
Jul 21, 2016
Merged

Set NULL correctly on Alt-Delete #663

merged 1 commit into from
Jul 21, 2016

Conversation

justinclift
Copy link
Member

For #660

@justinclift justinclift added the bug Confirmed bugs or reports that are very likely to be bugs. label Jul 20, 2016
@justinclift justinclift self-assigned this Jul 20, 2016
@justinclift
Copy link
Member Author

@innermous There are two other places where QByteArray() are used, which might need changing too:

I don't really grok the difference (yet), so am unsure. What do you think?

@justinclift
Copy link
Member Author

justinclift commented Jul 21, 2016

So, I tried setting those other two lines to QVariant(), to see what would happen.

The build barfs complaining there's no valid conversion type. QHexEdit::setData() really wants a QByteArray() for those two. 😄

With the one changed in this PR, it's a different setData(). This one is QAbstractItemModel::setData(), which prefers QVariant().

With the aid of F2 in Qt Creator (to show the definition under the cursor), I think I'm learning. 😉

Thanks for pointing this out @innermous. 😄

@justinclift justinclift merged commit 906aa8c into sqlitebrowser:master Jul 21, 2016
@justinclift justinclift deleted the issue660v2 branch July 21, 2016 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant