Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database toolbar actions not updating after deleting a table #600

Merged
merged 1 commit into from
May 22, 2016

Conversation

revolter
Copy link
Member

After deleting a table, the Delete Table button remained active and if pressed, it tried to delete table ''.

@justinclift
Copy link
Member

Ahhh, interesting catch. Give me a few minutes to verify this, then if good I'll merge it. 😄

@justinclift justinclift added the bug Confirmed bugs or reports that are very likely to be bugs. label May 21, 2016
@justinclift justinclift merged commit 6b8a44f into sqlitebrowser:master May 22, 2016
@justinclift
Copy link
Member

Thanks @revolter, that's perfect. 😁

@revolter
Copy link
Member Author

Yaaay, my first sqlitebrowser PR and accepted PR ❤️

@justinclift
Copy link
Member

justinclift commented May 22, 2016

😀

More are welcome. *hint* hint

Just sayin'. 😄

@revolter
Copy link
Member Author

Of course 😄

@MKleusberg
Copy link
Member

@revolter Many thanks from my side, too, for this PR 😃 If you feel like doing more PRs but need any help with it just open an issue or a half-finished PR and we'll try our best to help you.

@revolter
Copy link
Member Author

Sure thing, I do have some bugs which I didn't have time to address.

Also, is it a good practice to create a separate branch for every PR, right?

@justinclift
Copy link
Member

Yeah, that's generally the best practise approach.

That way your patches don't depend on each other, which can be a bit weird if an earlier one needs changing before it gets accepted. 😄

@justinclift
Copy link
Member

justinclift commented May 24, 2016

Also, I think if you accidentally have multiple PR's in one branch, they'll overwrite each other in GitHub.

@revolter
Copy link
Member Author

Ok, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants