-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix database toolbar actions not updating after deleting a table #600
Conversation
Ahhh, interesting catch. Give me a few minutes to verify this, then if good I'll merge it. 😄 |
Thanks @revolter, that's perfect. 😁 |
Yaaay, my first sqlitebrowser PR and accepted PR ❤️ |
😀 More are welcome. *hint* hint Just sayin'. 😄 |
Of course 😄 |
@revolter Many thanks from my side, too, for this PR 😃 If you feel like doing more PRs but need any help with it just open an issue or a half-finished PR and we'll try our best to help you. |
Sure thing, I do have some bugs which I didn't have time to address. Also, is it a good practice to create a separate branch for every PR, right? |
Yeah, that's generally the best practise approach. That way your patches don't depend on each other, which can be a bit weird if an earlier one needs changing before it gets accepted. 😄 |
Also, I think if you accidentally have multiple PR's in one branch, they'll overwrite each other in GitHub. |
Ok, thanks again! |
After deleting a table, the
Delete Table
button remained active and if pressed, it tried to delete table''
.