Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crash when removing records #590

Merged
merged 1 commit into from
May 14, 2016
Merged

Prevent crash when removing records #590

merged 1 commit into from
May 14, 2016

Conversation

vtronko
Copy link
Member

@vtronko vtronko commented May 14, 2016

Steps to reproduce this issue:

  1. Open table with no records at all (or remove them all)
  2. Press Ctrl+A
  3. Press "Delete record"
  4. Watch the world burn
ASSERT: "!isEmpty()" in file /usr/include/qt/QtCore/qlist.h, line 335
The program has unexpectedly finished.

@justinclift
Copy link
Member

justinclift commented May 14, 2016 •
edited
Loading

Ahhh, interesting crash. 😄 I'll take a look at verifying it, then this fix, then merge it in a few hours. (doing other stuff atm)

@justinclift justinclift added bug Confirmed bugs or reports that are very likely to be bugs. crash labels May 14, 2016
@justinclift
Copy link
Member

Yep, bug and fix confirmed. Thanks heaps for this @innermous. 😄

@justinclift justinclift merged commit c943522 into sqlitebrowser:master May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs. crash
Projects
None yet
Milestone
3.9.0 - Something Nifty Treads Here L...
Development

Successfully merging this pull request may close these issues.
2 participants
@vtronko @justinclift