Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled bufferedDraw for smooth fonts on Retina and high DPI displays #575

Merged
merged 1 commit into from Apr 26, 2016
Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2016

A proposed fix for this issue
#498 (comment)

@justinclift
Copy link
Member

Yep, that's the perfect way to do it. 😄

This looks good to me, so I'll merge it now. The nightly build tomorrow will have the change in it, which would be nifty for you to verify and report back success/failure. 😄

@justinclift justinclift merged commit f0d6925 into sqlitebrowser:master Apr 26, 2016
@justinclift
Copy link
Member

@MKleusberg You might want to cast your eye over this (one liner), just in case. 😉

@ghost
Copy link
Author

ghost commented Apr 27, 2016

Can confirm that the nightly build works on OS X with Retina display. I tested it on a Mac without retina display as well, no negative effects.

screenshot 2016-04-28 09 11 05

@justinclift
Copy link
Member

justinclift commented Apr 27, 2016

Awesome. Such a simple change, but so much effect. Well done!

What's your next Pull Request going to be? 😀

@ghost
Copy link
Author

ghost commented Apr 27, 2016

😄 yeah, just an easy one liner. The process of finding out what to change gave me a chance to see how qt works, which I've never used before. It was pretty interesting, but not too complicated as the code, to my novice eye, is really clean and well organised (so is this app's). As for what the future holds, I'm just gonna keep learning and programming, hey? 😀

@ghost
Copy link
Author

ghost commented Apr 27, 2016

But I did notice that my professor always has to make some changes to the font size in class (prefs aren't saved because the machine boots from a master OS image on every reboot) so I was thinking about adding a "Presenter" mode checkbox or something to the preferences pane. Might be a nifty little project for me to dabble in C++. I won't make any pull requests until that branch is rock solid though.

@justinclift
Copy link
Member

Sure, a presenter mode would be a welcome addition. Get it mostly right, and we can look over the code and possibly make some suggestions, or even make a few test builds for people to try it with. 😄

@justinclift
Copy link
Member

Hmmm, second thought. With that master OS image... er... how about getting the font size changed there, so its "correct" at the source? 😉

@MKleusberg
Copy link
Member

One extra suggestion here: if this fix has no side-effects you should think about proposing it to the upstream QScintilla project. Otherwise your change won't be included in versions of DB4S which are compiled against an external QScintilla library (like on Linux distros) or might be overridden when we update the QScintilla source in our repository and forget about this...

@justinclift
Copy link
Member

Good idea. 😄

@revolter
Copy link
Member

revolter commented Aug 4, 2016

@nickberry17, Did you manage to propose the fix to QScintilla?

@ghost
Copy link
Author

ghost commented Aug 5, 2016

Regrettably, I have not. I did research it, and found a commit stating a permanent fix had already been implemented in v2.8.1 that removes the need to disable bufferedDraw, though the compiled version does not seem to behave as such. I think it should be brought to the maintainer's attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. osx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants