-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update winget-releaser to latest #3690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, but I have two questions before I merge.
- Update winget-releaser to latest #3690 (comment)
- I was wondering why you chose the
main
branch instead of a stable release like 'v2'?
steps: | ||
- uses: vedantmgoyal2009/winget-releaser@v2 | ||
- uses: vedantmgoyal9/winget-releaser@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accout names are similar, did you change your GitHub account name recently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd changed my username.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for confirmation.
I actually had one more question, but I think you may have missed it, so I'd appreciate it if you could check.
@vedantmgoyal9 Looking over this, it seems to still be waiting for info regarding the chosen version? ie is choosing a fixed version/tag (likely known to work) better than choosing the @lucydodo With a GitHub username change like this, I guess we should try contacting the previous account holder to verify it's indeed the same person, just to be on the safe side. 😄 |
@vedantmgoyal9 ping? |
Hello, Apologies for missing the mention. The action is a wrapper around Komac (a tool developed by a winget-pkgs moderator for manifest creation and submission) with some extra pre and post commands to provide extra functionality. Previously, I was using a JavaScript-based GH-action, which involved updating npm dependencies and hence, versioning the action. But now, I've rewritten the action in PowerShell as a composite GH-action, removing external dependencies and reducing vulnerability risks. This new setup performs the same tasks without requiring frequent updates, unless there are major changes in PowerShell or Komac's command-line interface. |
Thanks for the info @vedantmgoyal9. 😄 @lucydodo Is the above ok with you? |
@justinclift might be that you wanted to ping @vedantmgoyal2009 instead? |
@mgrojo Nah, it seems like it was an actual username change on GitHub. For example, even trying to load the old repository (https://github.com/vedantmgoyal2009/winget-releaser) automatically bounces to the new repository location (https://github.com/vedantmgoyal9/winget-releaser). I've seen that happen before with official repository transfers between accounts, so (to me) that seems to line up ok. |
LGTM. Thanks for the contribution. |
No description provided.