qscintilla: get rid 'Not relevant classes found' messages from build log #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh yeah, this makes a lot of sense. The only reason why it's all in the QSCINTILLA_MOC_HDR list is that when I included the QScintilla library I wanted it to build quickly in order to start coding as soon as possible. But then I never cleaned up the build files 😃 As it builds without any issues using Qt4 as well as Qt5 I'll go ahead and just merge this. Good job, by the way, with paying this much attention to detail 👍 |
MKleusberg
added a commit
that referenced
this pull request
May 20, 2015
qscintilla: get rid 'Not relevant classes found' messages from build log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building of qscintilla library using CMake in build log there are many notes, something like:
That's because XPM class, for example, not inherited from QObject and does not require processing with Qt Meta Object Compiler.
Possible solution is to move these classes from QSCINTILLA_MOC_HDR into QSCINTILLA_HDR in file CMakeLists.txt
@MKleusberg, what you think about this?