Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: translations are not being installed via make install #310

Merged
merged 1 commit into from
May 12, 2015
Merged

fix: translations are not being installed via make install #310

merged 1 commit into from
May 12, 2015

Conversation

schdub
Copy link
Contributor

@schdub schdub commented May 12, 2015

#304

  • translation files (.qm) moved into Qt resources;
  • still can put the .qm file in /translations directory next to the executable file and this translation will have a higher priority than .qm file from resources for the same locale.

@rp-, please review (not sure about CMake).

rp- added a commit that referenced this pull request May 12, 2015
@rp-
Merge pull request #310 from schdub/issue304
dd333ce 
fix: translations are not being installed via make install
@rp- rp- merged commit dd333ce into sqlitebrowser:master May 12, 2015
@rp-
Copy link
Contributor

rp- commented May 12, 2015

works well, merged

@justinclift justinclift added bug Confirmed bugs or reports that are very likely to be bugs. fix applied labels May 12, 2015
@justinclift
Copy link
Member

Thanks guys. 😀

@schdub schdub mentioned this pull request May 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Milestone
3.7.0 - Something Funky Goes Here
Development

Successfully merging this pull request may close these issues.
3 participants
@schdub @rp- @justinclift