Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlitetablemodel: return back 'cheap BLOB test' for data DisplayRole #285

Merged
merged 1 commit into from
May 5, 2015

Conversation

schdub
Copy link
Contributor

@schdub schdub commented May 1, 2015

@justinclift
Copy link
Member

@Samir-Aguiar ping?

@MKleusberg
Copy link
Member

In my opinion we can merge this as it makes a lot of sense in a SQLite environment: with this the behaviour when displaying the content of a cell depends on the actual content and not on the data type which fits well into SQLite's pragmatic handling of data types. The only thing I'm thinking of is that it might be a good idea to improve the binary test made here while being on it. Maybe check for more than the null character but still in an efficient manner?

@ghost
Copy link

ghost commented May 3, 2015

Sorry for the lateness guys, I'm moving from one country to another so those last days are being pretty busy. I'll get back to this next week but no problem if you guys want to merge it :)

@justinclift justinclift added the enhancement Feature requests. label May 3, 2015
@justinclift
Copy link
Member

@MKleusberg k, so merge this one now, and we can tweak it later?

MKleusberg added a commit that referenced this pull request May 5, 2015
sqlitetablemodel: return back 'cheap BLOB test' for data DisplayRole
@MKleusberg MKleusberg merged commit 0fb1b3b into sqlitebrowser:master May 5, 2015
@MKleusberg
Copy link
Member

Sounds reasonable :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants