Remove activateWindow() when EditDock is toggled
#1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to set sqlitebrowser as active window when updating the main application window. The `activateWindow()` call prevents switching workspaces in GNOME and Cinnamon desktops. Fixes #934
|
@kehugter Cool, this looks like the right kind of thing. I'm installing Fedora 26 with Gnome in a VM now (it should have the problem), and will test this PR out once that's installed and I can try things out. 😄 |
|
Yep, this fixes the problem here when testing on Fedora 25. Thanks @kehugter, that's really good. 😄 |
This was referenced Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to set sqlitebrowser as active window when updating
the main application window. The
activateWindow()call preventsswitching workspaces in GNOME and Cinnamon desktops.
Fixes #934