Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed project to "DB Browser for SQLite" #101

Merged
merged 1 commit into from
Sep 22, 2014
Merged

Renamed project to "DB Browser for SQLite" #101

merged 1 commit into from
Sep 22, 2014

Conversation

justinclift
Copy link
Member

No description provided.

@MKleusberg
Copy link
Member

You missed the CMakeLists.txt file ;)

@justinclift
Copy link
Member Author

Oops. Will fix later today. 😄

@justinclift justinclift added the enhancement Feature requests. label Sep 16, 2014
@justinclift justinclift self-assigned this Sep 16, 2014
@justinclift
Copy link
Member Author

Found out why. Bad grep on my part. I used this:

$ grep -ri "database browser" *| grep -v .ts

When I should have used this:

$ grep -ri "database browser" *| grep -v "\.ts"

@justinclift
Copy link
Member Author

Now, the next question is... do we want to make the change right away with a 3.3.2 release, or should we just do it with the next (3.4.0) release?

I'm kind of tempted to be lazy, and do it with the 3.4.0 release... 😄

@MKleusberg
Copy link
Member

Sorry that I only noticed now but in the distri/sqlitebrowser.desktop file it still says "SQLiteBrowser". Maybe we should change that as well, for consistency's sake.

I'd also opt for making this part of the 3.4.0 release. This time the change is so subtle that it's probably not really worth the annoyance for anybody ;)

@justinclift
Copy link
Member Author

Ahhh, well spotted. Fix coming up.

@justinclift
Copy link
Member Author

@MKleusberg With the "Name=" field in that file, does it have to be a 1 word name (eg DBBrowser4SQLite) or can we use the long version? eg DB Browser for SQLite

@justinclift
Copy link
Member Author

Now I'm looking closer, there are other places I missed as well. Fixing them too...

@MKleusberg
Copy link
Member

@justinclift You're definitely allowed to have spaces in there. That's the text that shows up in the application menu of your Linux desktop.

Comment[de]=SQLiteBrowser ist ein GUI-Editor für SQLite-Datenbanken
Name=DB Browser for SQLite
Comment=DB Browser for SQLite is a light GUI editor for SQLite databases
Comment[de]=DB Browser für SQLite ist ein GUI-Editor für SQLite-Datenbanken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this seem ok? "DB Browser für SQLite"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a correct translation but I'd stay with 'DB Browser for SQLite' in the German line as well since names are usually not translated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@justinclift
Copy link
Member Author

When you guys reckon this is good, please merge it. 😄

@justinclift
Copy link
Member Author

Heh, and it's saying merge conflict now... I'll fix it later. 😉

@Z4us
Copy link

Z4us commented Sep 20, 2014

If github allows it you may change the name of the entire project to e.g. Browser4SQLite or extremely short B4S (1337 [leet] lingo: 845 ;-D)

@justinclift
Copy link
Member Author

Yeah, we could do that. We're trying to avoid changing the project URL, registering new domain names, and so on though. 😉

@justinclift
Copy link
Member Author

Should be ready to merge now. 😄

justinclift added a commit that referenced this pull request Sep 22, 2014
Renamed project to "DB Browser for SQLite"
@justinclift justinclift merged commit 6195896 into sqlitebrowser:master Sep 22, 2014
@justinclift justinclift deleted the renamev2 branch September 22, 2014 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants