-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed project to "DB Browser for SQLite" #101
Conversation
You missed the CMakeLists.txt file ;) |
Oops. Will fix later today. 😄 |
Found out why. Bad grep on my part. I used this:
When I should have used this:
|
Now, the next question is... do we want to make the change right away with a 3.3.2 release, or should we just do it with the next (3.4.0) release? I'm kind of tempted to be lazy, and do it with the 3.4.0 release... 😄 |
Sorry that I only noticed now but in the distri/sqlitebrowser.desktop file it still says "SQLiteBrowser". Maybe we should change that as well, for consistency's sake. I'd also opt for making this part of the 3.4.0 release. This time the change is so subtle that it's probably not really worth the annoyance for anybody ;) |
Ahhh, well spotted. Fix coming up. |
@MKleusberg With the "Name=" field in that file, does it have to be a 1 word name (eg DBBrowser4SQLite) or can we use the long version? eg DB Browser for SQLite |
Now I'm looking closer, there are other places I missed as well. Fixing them too... |
@justinclift You're definitely allowed to have spaces in there. That's the text that shows up in the application menu of your Linux desktop. |
Comment[de]=SQLiteBrowser ist ein GUI-Editor für SQLite-Datenbanken | ||
Name=DB Browser for SQLite | ||
Comment=DB Browser for SQLite is a light GUI editor for SQLite databases | ||
Comment[de]=DB Browser für SQLite ist ein GUI-Editor für SQLite-Datenbanken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this seem ok? "DB Browser für SQLite"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a correct translation but I'd stay with 'DB Browser for SQLite' in the German line as well since names are usually not translated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
When you guys reckon this is good, please merge it. 😄 |
Heh, and it's saying merge conflict now... I'll fix it later. 😉 |
If github allows it you may change the name of the entire project to e.g. Browser4SQLite or extremely short B4S (1337 [leet] lingo: 845 ;-D) |
Yeah, we could do that. We're trying to avoid changing the project URL, registering new domain names, and so on though. 😉 |
Should be ready to merge now. 😄 |
Renamed project to "DB Browser for SQLite"
No description provided.