-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in SqliteTableModel::getForeignKeyClause #942
Comments
Awesome @schdub. @MKleusberg has been working on Foreign Key stuff recently, so this will probably interest him. 😄 |
Can't reproduce it. |
UPD: Sorry, I am able to reproduce it now. This happens if one hovers a cell for at least 3-4 seconds. |
Tooltips in execute SQL tab can't be shown right now, since foreign key functionality relies on fixed size tables as static database objects. |
This is probably just temporary solution. Tooltip code was written specifically for Browse Data tab, so it requires some versatile changes.
Cool, sounds like progress in the right direction. 😄 |
Yeah, I don't there is much more that we can do right now. In order to support the foreign key tooltip + shortcut for queries in the Execute SQL tab we'd have to parse and understand SELECT statements and those can become quite complex. We'd need a mechanism to track which column in the results table comes from which column of which table in the database. It's the same effort that's needed to implement editing in the results view (see #393, and #141 as well). |
@MKleusberg Should this be closed then? It sounds like this is fixed, even though the solution isn't perfect for the long term. |
Yeah, I guess we can close it. If you have the time you could open a meta issue for this instead to collect use cases for a full SELECT statement parser. This here is one of them, the two issues I've mentioned above are others, and maybe there are more. |
Details for the issue
Useful extra information
For some reason SqliteTableModel::m_sTable is empty:
I'm opening this issue because:
I'm using DB4S on:
I'm using DB4S version:
I have also:
The text was updated successfully, but these errors were encountered: