Hangs when selecting all the records and deleting them #856

revolter · 2016-11-03T09:01:06Z

prutz1311 · 2016-11-03T22:58:29Z

What about using DELETE FROM tableWHERErowid IN ( ... ) here

Lines 873 to 876 in 60e4cb7

    
           QString statement = QString("DELETE FROM %1 WHERE %2='%3';") 
        
                   .arg(sqlb::escapeIdentifier(table)) 
        
                   .arg(sqlb::escapeIdentifier(getObjectByName(table).table.rowidColumn())) 
        
                   .arg(rowid);

in all cases regardless of whether one or multiple records should be deleted?

justinclift · 2016-11-03T23:28:22Z

At first thought, yeah, that sounds like it would work. At least for rowid tables anyway.

Want to submit a PR? 😄

revolter · 2016-11-04T01:12:37Z

It looks like that method is called for each row here, so maybe this is where the IDs array should be created and passed to a new method that builds the correct query.

prutz1311 · 2016-11-04T23:51:59Z

It turns out that the method removeRow of SqliteTableModel object gets invoked here, and since SqliteTableModel is a subclass of QAbstractTableModel which is, in turn, a subclass of QAbstractItemModel, the following code from Qt library is executed:

inline bool QAbstractItemModel::removeRow(int arow, const QModelIndex &aparent)
{ return removeRows(arow, 1, aparent); }

that is, it forces us to have only 1 row deleted.
My backtrace on deletion looks like this:

(gdb) backtrace
#0  DBBrowserDB::deleteRecord (this=0xba25c8, table=..., rowid=...)
    at /home/oleg/Документы/программирование/Sources/sqlitebrowser/src/sqlitedb.cpp:870
#1  0x00000000005ee5cf in SqliteTableModel::removeRows (this=0xb949d0, row=40, count=1, parent=...)
    at /home/oleg/Документы/программирование/Sources/sqlitebrowser/src/sqlitetablemodel.cpp:415
#2  0x00000000005a3a98 in QAbstractItemModel::removeRow (this=0xb949d0, arow=40, aparent=...)
    at /opt/qt57/include/QtCore/qabstractitemmodel.h:347
#3  0x000000000058fe72 in MainWindow::deleteRecord (this=0xba24a0)
    at /home/oleg/Документы/программирование/Sources/sqlitebrowser/src/MainWindow.cpp:589
#4  0x0000000000649bff in MainWindow::qt_static_metacall (_o=0xba24a0, _c=QMetaObject::InvokeMetaMethod, _id=17, _a=0x7fffffffd550)
    at /home/oleg/Документы/программирование/Sources/sqlitebrowser/build/moc_MainWindow.cpp:438
#5  0x00007ffff6cfc9d5 in QMetaObject::activate(QObject*, int, int, void**) () from /opt/qt57/lib/libQt5Core.so.5
#6  0x00007ffff7473f52 in QAbstractButton::clicked(bool) () from /opt/qt57/lib/libQt5Widgets.so.5
#7  0x00007ffff747414a in ?? () from /opt/qt57/lib/libQt5Widgets.so.5
#8  0x00007ffff7475648 in ?? () from /opt/qt57/lib/libQt5Widgets.so.5
#9  0x00007ffff74757c4 in QAbstractButton::mouseReleaseEvent(QMouseEvent*) () from /opt/qt57/lib/libQt5Widgets.so.5
#10 0x00007ffff73d85da in QWidget::event(QEvent*) () from /opt/qt57/lib/libQt5Widgets.so.5
#11 0x00007ffff7394cbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /opt/qt57/lib/libQt5Widgets.so.5
#12 0x00007ffff739c61b in QApplication::notify(QObject*, QEvent*) () from /opt/qt57/lib/libQt5Widgets.so.5
#13 0x00007ffff6cd48e5 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /opt/qt57/lib/libQt5Core.so.5
#14 0x00007ffff739b0a3 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool)
    () from /opt/qt57/lib/libQt5Widgets.so.5
#15 0x00007ffff73f14e1 in ?? () from /opt/qt57/lib/libQt5Widgets.so.5
#16 0x00007ffff73f3933 in ?? () from /opt/qt57/lib/libQt5Widgets.so.5
#17 0x00007ffff7394cbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /opt/qt57/lib/libQt5Widgets.so.5
#18 0x00007ffff739bc40 in QApplication::notify(QObject*, QEvent*) () from /opt/qt57/lib/libQt5Widgets.so.5
#19 0x00007ffff6cd48e5 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /opt/qt57/lib/libQt5Core.so.5
#20 0x00007ffff798319b in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) ()
   from /opt/qt57/lib/libQt5Gui.so.5
#21 0x00007ffff7984cf5 in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) ()
   from /opt/qt57/lib/libQt5Gui.so.5
#22 0x00007ffff7966dab in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) ()
   from /opt/qt57/lib/libQt5Gui.so.5
#23 0x00007fffef8b13f0 in ?? () from /opt/qt57/plugins/platforms/../../lib/libQt5XcbQpa.so.5
#24 0x00007ffff4755e04 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#25 0x00007ffff4756048 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#26 0x00007ffff47560ec in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#27 0x00007ffff6d2329c in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /opt/qt57/lib/libQt5Core.so.5
#28 0x00007ffff6cd2bbb in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /opt/qt57/lib/libQt5Core.so.5
#29 0x00007ffff6cda9b6 in QCoreApplication::exec() () from /opt/qt57/lib/libQt5Core.so.5
#30 0x0000000000634f58 in main (argc=2, argv=0x7fffffffe3b8)
    at /home/oleg/Документы/программирование/Sources/sqlitebrowser/src/main.cpp:13
(gdb)

It seems to me that we cannot delete multiple records at once if we rely on table model of Qt.
Should we bypass the inline bool QAbstractItemModel::removeRow method call?

justinclift · 2016-11-05T05:39:44Z

@MKleusberg What do you reckon?

When trying to delete all records or large number of them (~5000) (selecting them and pressing Delete Record on Data tab), it takes too much time to execute this operation due to large number of queries like `DELETE * FROM 'table' WHERE '_rowid_' = id`.

revolter · 2016-12-21T08:19:31Z

Can't we use the removeRows method instead?

justinclift · 2017-05-20T10:08:30Z

@revolter Would you have time to see if this is working decently in the nightlies? @innermous updated the deletion code to use removeRows, so in theory it should be ok now. 😄

justinclift · 2017-08-20T18:41:32Z

@revolter Ping. But, check with 3.10.0 release instead. 😄

justinclift · 2017-11-17T17:08:49Z

Closing this as it seems to have been fixed ages ago. 😄

revolter · 2017-11-17T17:12:26Z

@justinclift, Sorry about that, I'm way way behind with the notifications. It does delete a lot of records in an instant, though I still think it would make sense for the delete button's text to change to Delete records as soon as you select more than one record.

justinclift · 2017-11-17T17:18:26Z

Ahhh, that's a good point. Yeah, that would be a small bit of nicety we could add. 😄

Change the label of the "Delete record" button in the Browse Data tab to "Delete records" when multiple records are selected. See issue #856.

MKleusberg · 2017-11-17T22:47:44Z

Should be fixed 😃

@revolter Same for me, I've totally lost track of the open issues and notifications lately 😉

mgrojo · 2018-01-07T20:26:19Z

I suppose, this can be closed 😃

justinclift · 2018-01-07T21:01:31Z

Good point. Thanks @mgrojo. 😄

justinclift added bug Confirmed bugs or reports that are very likely to be bugs. osx labels Nov 3, 2016

justinclift pushed a commit that referenced this issue Nov 25, 2016

Fix hanging when deleting large number of records (#856) (#870)

17369b6

vtronko pushed a commit that referenced this issue Dec 29, 2016

Fix hanging when deleting large number of records (#856) (#870)

5d0c1d9

justinclift added the response requested label May 20, 2017

justinclift added this to the 3.10.0 - A Rubber Cactus Has Many Uses milestone May 20, 2017

justinclift closed this as completed Nov 17, 2017

justinclift removed the response requested label Nov 17, 2017

justinclift reopened this Nov 17, 2017

MKleusberg added a commit that referenced this issue Nov 17, 2017

Change label of "Delete record" button to reflect number of records

5fbf5ca

Change the label of the "Delete record" button in the Browse Data tab to "Delete records" when multiple records are selected. See issue #856.

justinclift closed this as completed Jan 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hangs when selecting all the records and deleting them #856

Hangs when selecting all the records and deleting them #856

revolter commented Nov 3, 2016

prutz1311 commented Nov 3, 2016 •

edited

Loading

justinclift commented Nov 3, 2016

revolter commented Nov 4, 2016

prutz1311 commented Nov 4, 2016 •

edited

Loading

justinclift commented Nov 5, 2016

revolter commented Dec 21, 2016

justinclift commented May 20, 2017

justinclift commented Aug 20, 2017

justinclift commented Nov 17, 2017

revolter commented Nov 17, 2017

justinclift commented Nov 17, 2017

MKleusberg commented Nov 17, 2017

mgrojo commented Jan 7, 2018

justinclift commented Jan 7, 2018

Hangs when selecting all the records and deleting them #856

Hangs when selecting all the records and deleting them #856

Comments

revolter commented Nov 3, 2016

Details for the issue

Useful extra information

I'm opening this issue because:

I'm using DB4S on:

I'm using DB4S version:

I have also:

prutz1311 commented Nov 3, 2016 • edited Loading

justinclift commented Nov 3, 2016

revolter commented Nov 4, 2016

prutz1311 commented Nov 4, 2016 • edited Loading

justinclift commented Nov 5, 2016

revolter commented Dec 21, 2016

justinclift commented May 20, 2017

justinclift commented Aug 20, 2017

justinclift commented Nov 17, 2017

revolter commented Nov 17, 2017

justinclift commented Nov 17, 2017

MKleusberg commented Nov 17, 2017

mgrojo commented Jan 7, 2018

justinclift commented Jan 7, 2018

prutz1311 commented Nov 3, 2016 •

edited

Loading

prutz1311 commented Nov 4, 2016 •

edited

Loading