Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in Browse Data Tab when copying blank values #626

Closed
AO-StreetArt opened this issue Jun 17, 2016 · 9 comments
Closed

Crash in Browse Data Tab when copying blank values #626

AO-StreetArt opened this issue Jun 17, 2016 · 9 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs. crash

Comments

@AO-StreetArt
Copy link

I have seen repeated crashes when the following actions are taken, and this is reproducible with the most recent nightly build.

  1. With a DB open, go to the 'Browse Data' tab
  2. Select a blank record (note: when I say blank I mean "", not (NULL). As in an empty string). These can easily be generated by a CSV import without all fields populated for every row
  3. Ctrl+C to copy the cell value
  4. Select a cell with a non-null value in it, Ctrl+V to paste
  5. The application crashes

I am using Windows 7 Enterprise

@justinclift
Copy link
Member

Ahhh yeah, that definitely sounds like the kind of thing that could happen.

Thanks for reporting it @AO-StreetArt. 😄

@justinclift justinclift added bug Confirmed bugs or reports that are very likely to be bugs. crash labels Jun 17, 2016
@vtronko
Copy link
Member

vtronko commented Jun 18, 2016

In addition, I wanna say, when copying NULL field and inserting it in another cell just inserts NULL as text.

@justinclift
Copy link
Member

@innermous Awesome! 😁

I've just reopened this because before we close stuff, we always ask the person who created the bug report to confirm it first. That's because even though most of the time things are ok, sometimes fixes turn out to be not-quite-as-complete as we were expecting. Or the bug reporter finds an unexpected side effect. 😉 So asking the bug reporter to verify things first leads to a better result.

@AO-StreetArt Would you be ok to try the latest nightly build (download locations are on the front page of our project) and let us know if it's working properly for you now? 😄

@justinclift
Copy link
Member

@AO-StreetArt Ping?

@AO-StreetArt
Copy link
Author

Sorry for the delayed response, absolutely ill test it at work tomorrow when I use the browser :)

@AO-StreetArt
Copy link
Author

I have re-tested the issue with the latest nightly build and the crash is no longer observed.

I tested copying a blank value into a populated cell, copying a blank value into a blank cell, copying a blank value into a null cell, and copying blank values into cells with different data types. All tests passed.

Note: It is interesting that the Browse Data tab doesn't perform validations on entries into the cells based on data type. Was this intentional?

Closing this ticket, thank you for the quick response!

@justinclift
Copy link
Member

Awesome, thanks heaps for testing it and getting back to us @AO-StreetArt. 😄

@justinclift
Copy link
Member

@AO-StreetArt Just noticed your question about no validation of entries based on data type.

Just in case you're still curious about it, yeah, this is intentional. 😉

SQLite itself considers the flexibility of datatypes to be a feature, and we'd be opening a weird can of worms if we didn't follow with the official position with it. 😄

    https://www.sqlite.org/datatype3.html

Hope that helps. 😄

@AO-StreetArt
Copy link
Author

AO-StreetArt commented Jul 13, 2016

Very good explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs. crash
Projects
None yet
Development

No branches or pull requests

3 participants