Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to look at temporary table in Browse Data Tab #2348

Closed
gchan1234 opened this issue Jul 30, 2020 · 7 comments
Closed

Unable to look at temporary table in Browse Data Tab #2348

gchan1234 opened this issue Jul 30, 2020 · 7 comments
Assignees
@MKleusberg
Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Milestone
3.12.1

Comments

@gchan1234
Copy link

Hi

I am unable to look at temporary tables in the Browse data table. It works in previous versions. When I click on the temporary table - it reverts to the first available table on the list
@justinclift
Copy link
Member

Ouch. That sounds like a bug. 😦

@justinclift justinclift added the bug Confirmed bugs or reports that are very likely to be bugs. label Jul 30, 2020
@MKleusberg
Copy link
Member

Yes, just noticed that too with attached databases. I'll look into it now. It's definitely something we need to fix for 3.12.1, so thanks for reporting this, @gchan1234! 😄

@MKleusberg MKleusberg added the release blocker Bugs that are serious enough to block our next release label Aug 4, 2020
@MKleusberg MKleusberg added this to the 3.12.1 milestone Aug 4, 2020
MKleusberg added a commit that referenced this issue Aug 4, 2020
@MKleusberg
Fix bug which made tables from other schemas inaccessible in Browse Data
b6e3db3 
Fix a bug which made tables from other schemas than the main schema
inaccessible in the Browse Data tab. Most notably this always selects
table "main"."tbl" instead of for example "temp"."tbl".

See issue #2348.
@MKleusberg
Copy link
Member

This should be fixed now. Can you check again using tomorrow's nightly build, @gchan1234?

@MKleusberg MKleusberg self-assigned this Aug 4, 2020
@MKleusberg MKleusberg added needs merging with upcoming release branch and removed release blocker Bugs that are serious enough to block our next release labels Aug 4, 2020
@justinclift
Copy link
Member

@MKleusberg Any idea when this bug was introduced?

@gchan1234
Copy link
Author

@MKleusberg Thanks it's fixed :)

@MKleusberg
Copy link
Member

@justinclift Looks like the bug was introduced by this commit a09df5b. So it's only present in the nightlies.

@gchan1234 Awesome. Thanks for testing! 😄

@justinclift
Copy link
Member

Looks like the bug was introduced by this commit a09df5b. So it's only present in the nightlies.

Cool. 😄

mgrojo added a commit that referenced this issue Aug 22, 2020
@mgrojo
Fix bug which made tables from other schemas inaccessible in Browse Data
f5a2b10 
Fix a bug which made tables from other schemas than the main schema
inaccessible in the Browse Data tab. Most notably this always selects
table "main"."tbl" instead of for example "temp"."tbl".

See issue #2348.

# Conflicts:
#	src/TableBrowser.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MKleusberg MKleusberg

Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Milestone
3.12.1
Development

No branches or pull requests
4 participants
@justinclift @MKleusberg @mgrojo @gchan1234