-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application terminates when adding or viewing incomplete XML to TEXT field (64-bit only) #2321
Comments
Thanks for reporting this @seattleite7, that sounds like the kind of thing we'll want to fix sooner rather than later. 😉 |
Does this do this every time? Even after restarting DB4S? I tried a bunch of other actions (just in case) but couldn't trigger the crash. |
@chrisjlocke Yes you followed the steps correctly. I don't get the crash on 32-bit. But I get it every time on 64-bit even after restarting DB4S. |
Thanks for confirming. |
@chrisjlocke "crash" means "terminates immediately", no error message. |
Excellent, thanks. |
Weird. I cannot reproduce it either under Linux. So the problem is only present in the 64 bit version but not for all users. By the way, with the current version I cannot longer run the ZIP version of Windows under Wine. It crashes immediately, both in the 32 bits as in the 64 bit version. It might be a problem in Wine, but it doesn't happen with v3.11.2. |
Do the nightlies crash too? |
The nightlies too. It faults with these details (in case it gives some hint to anyone, not my case):
|
@mgrojo Interesting wine crash there. How easy would it be for you to figure out when it started crashing? eg by trying various of the win nightly builds We can probably narrow down if it's something we did, or if it's more likely something to do with Qt 5.12.8. |
@seattleite7 I can't reproduce the crash either. Can you maybe follow the instructions here and copy the debug information you get after the crash in here? |
I had QT 5.9.2 installed. When I uninstalled it, it did not crash anymore. Below is the debug information for the crash (see bold)
|
Ahhh. So the wrong Qt libraries were being loaded. In hind sight, that makes sense for the crash to happen. But (in theory), it's weird just having Qt 5.9.2 installed was somehow getting that to be loaded instead of the Qt 5.12.8 libraries our installer includes. Maybe some kind of system setting or environment variable thing? |
Interesting. You can see how the different Qt versions are mixed here:
I wonder why it's just loading |
Yeah, I was thinking the same. We probably don't use it. On the other hand DB4S does try to load it for whatever reason. |
The line right above that is the Qt SVG imageformat dll:
That's what our CMakeLists.txt has too. No idea where the Maybe there's some kind of override in an environment variable or similar? |
Looking at the Qt source code, it seems like their image formats project doesn't have a plugin for SVG. Instead that plugin is part of the QtSVG project. So maybe that means that the SVG plugin depends on the entire SVG module and cannot be used as a standalone plugin like the other image formats. Also it looks like a Unfortunately I couldn't find any documentation on this but I believe |
Interesting. There's no We should be able to add that to our installer packages, by adding it to the right places. Probably these:
|
I'm too brain-dead tired atm to make that change. If someone else wants to get it done, it'll be automatically picked up by the build system tomorrow onwards. 😄 |
I had some time to test that. The last version to work was DB.Browser.for.SQLite-2019-11-11-win64.zip and the first which didn't work was DB.Browser.for.SQLite-2019-11-19-win64.zip. Looking at the history, the only one that I think could have had this effect would be 574303a which updated Qt from v5.12.5 to v5.12.6. |
This completely slipped my mind. I'll have a go at updating our Windows packaging so it includes the On that note, if it works then we'll probably need to do the same for macOS, Linux (AppImage) as well. |
@mgrojo Looks like Wine doesn't like that newer revision of Qt. 😦 There's a newer Qt revision out now (v5.12.9) too, compared to what we're using at the moment (v5.12.8). I'd been planning to update the build VM's with that anyway. We might as well see if it fixes things. If not, we could revert back to the older Qt 5.12.5. The updating to 5.12.8 was just because (in theory) newer Qt 5.12.x releases should be less buggy. That theory doesn't always seem to hold true though. 🤷 |
@seattleite7 Any interest in testing the new 64-bit Windows package here? https://nightlies.sqlitebrowser.org/latest/ That now includes the |
@justinclift |
Cool. 😄 Would you be ok to install Qt 5.9.2 again, and see if the crash comes back? Just wanting to make super sure adding the |
@justinclift No crashes with Qt 5.9.2 installed. |
Awesome! Sounds like including Thanks for taking the extra time to double check that @seattleite7. 😄 |
Details for the issue
What did you do?
'<?xml version="1.0" encoding="UTF-8"?>
(including the single quote at the beginning) and press applyUseful extra information
The text was updated successfully, but these errors were encountered: