Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Import bug - final row being missed #193

Closed
harysutanto opened this issue Feb 5, 2015 · 14 comments
Closed

CSV Import bug - final row being missed #193

harysutanto opened this issue Feb 5, 2015 · 14 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@harysutanto
Copy link

OS : OS X Yosemite 10.10.2
SQLiteBrowser Ver : 3.5.0

There's a bug when importing CSV files to database that the last record is not imported. Say that I have 10 records, then only 9 of them is imported, 20 records and only 19 imported. I use another SQLite browser app and the import works fine. Maybe you can work this bug out, I really love using your app for simplicity and easy to use.

This case is not always btw. I also have another CSV file that has 5 records in it, but all of them is imported. Maybe the bug occurs when the total records number exceeds certain number.

Also one more, when let's say I have 60 records in CSV file, when I click import there's a preview (when I was asked to name the table that is imported) of the records that's inside the CSV. But the preview only shows 19 of them, not all, even though the preview is in a scroll view. Maybe you can work this too so that it shows all of the records in the preview. Obviously when I import, only 59 of the records imported.

Thanks for your work on this app! Keep up the good work, and have a nice day!

@rp-
Copy link
Contributor

rp- commented Feb 5, 2015

Hi!

Can you provide such a CSV file? Maybe as real download, pasting it somewhere might ruin the linebreaks.

@harysutanto
Copy link
Author

Ok. Here is the CSV file with 10 records, and only the first 9 is imported.

CSV file is generated using Apple's Numbers app on OS X.

https://www.dropbox.com/s/e8pad14efeki5e7/ZWATCHACTIVITY.csv?dl=0

@rp-
Copy link
Contributor

rp- commented Feb 5, 2015

Thanks, I think I got it, looks like a stupid mistaken variable.

@rp-
Copy link
Contributor

rp- commented Feb 5, 2015

should be fixed: 8d55fd5

@rp- rp- added bug Confirmed bugs or reports that are very likely to be bugs. fix applied labels Feb 5, 2015
@harysutanto
Copy link
Author

Thanks for the fix!

@MKleusberg MKleusberg added this to the 3.6 milestone Feb 6, 2015
@justinclift
Copy link
Member

@harysutanto Sounds like this was just a simple mistaken variable bug, so should be fixed now. However, just to be 100% sure, would you be ok to test with the latest nightly and confirm back if it's ok or not? 😄

@harysutanto
Copy link
Author

Oh yeah, I already tested using the Feb 06, 2015 nightlies, and the problem is fixed but forgot to post here. Silly me!

Anyway, Thanks again for the fix!

@justinclift
Copy link
Member

Awesome. 😀

@justinclift justinclift changed the title CSV Import bug CSV Import bug - final row being missed Feb 8, 2015
@T1mL3arn
Copy link

Did want to create the same issue, but it is already here. Looks like it is needed to be reopen.

The problem

Final row is missed when importing csv file.

How to reproduce

  1. create csv file with just one row, e.g
hello
  1. Try to import it
  2. See no rows at all in the import dialog

Additional info

If add new empty line to the file, e.g

hello
# here is an empty line, the comment just to emphasize it

then import works.

The csv standard says the last record may or may not have an ending line break.

Tech info

WIndows 8.1, DB4S nightly Version 3.11.99 (Oct 3 2019)

@justinclift justinclift reopened this Oct 29, 2019
@justinclift
Copy link
Member

Thanks @T1mL3arn. Sounds like an unintended regression.

@MKleusberg Any interest in taking a look?

@MKleusberg
Copy link
Member

Thanks for pointing this out, @T1mL3arn! Can you check again with tomorrow's nightly build and see if it's working for your CSV file? 😄

@T1mL3arn
Copy link

Tested. Didn't see the issue anymore.

@justinclift
Copy link
Member

Awesome. Thanks for verifying things @T1mL3arn! Well done @MKleusberg. 😄

@MKleusberg
Copy link
Member

Cool, thanks for testing! I'm closing this issue again then 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

5 participants