-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's not possible to modify some tables #1733
Comments
The schema for those tables might contain some weird characters? Is it possible to email me the database? db4s [at] chrisjlocke [dot] co [dot] uk. You can send me a database sans data (executing the necessary 'delete from ...' commands from the 'execute sql' tab should still work, regardless of whether its fully read the schema) |
I updated my report. It works fine with version 3.10.1 Here is the table deifnition:
|
I assume you're aware thats not a SQLite compatible table definition. SQLite doesn't understand what 'char' is, or 'boolean'. It guesses, but it certainly isn't going to respect the 50 character field limits. I'm guessing its the 'entry' line causing grief - if you remove that, it works fine. It does appear valid ... its just our parser can't parse it. Doh. (See also: https://stackoverflow.com/questions/200309/sqlite-database-default-time-value-now) |
@gozzoo Out of curiosity, which database dialect is that SQL table definition created for? |
@justinclift No specific dialect in particular. I was expecting our projectt needs to outgrow sqlite pretty soon and wanted the database scripts to be portable. I never experimented running them on another dabtabase. |
Remove the window function grammar rules. I think they are not needed anyway as long as we only parse CREATE TABLE and CREATE INDEX statements and unexpectedly they do seem to cause problems. It it still worth investigating how this is possible but for now removing them seems like the best option. See issue #1733.
This is a very weird bug. Looks like it was introduced by adding some more rules to our grammar parser. And even when these rules aren't used anywhere they cause some problems. I have disabled them now which shouldn't cause any problems since we don't use them (yet). So with the next nightly build everything should work as expected again. Can you download the nightly build tomorrow and double check, @gozzoo? 😄 If it's working again in the nightly this is definitely a regression from 3.10.1 and the fix should definitely be included in a 3.11.1 release 😉 |
That reminds me... the build server has been off all day, so the nightlies haven't run yet. I'll manually kick off the build scripts now. Also just created a 3.11.1 milestone, so we have something to add this to. Made the due date two weeks from now, but we can adjust that sooner/later if need be. 😄 |
@gozzoo The Win64 nightly builds just finished, so they're online and ready for testing if/when you have a chance: |
It's working fine now, thanks. |
Thanks for letting us know. Will close this as its resolved (of sorts). |
Remove the window function grammar rules. I think they are not needed anyway as long as we only parse CREATE TABLE and CREATE INDEX statements and unexpectedly they do seem to cause problems. It it still worth investigating how this is possible but for now removing them seems like the best option. See issue #1733.
I've cherry-picked this over to the 3.11.x branch so it will be included in the 3.11.1 release 😄 Thanks again for pointing this out, @gozzoo! |
Thanks @MKleusberg |
Details for the issue
What did you do?
I opened a database with few existing tables. All tables did have multiple fields
What did you expect to see?
This is with version 3.10.1
What did you see instead?
For some tables there is no expand icon.
When I right-click the name of such table and select 'Modify table' I see defintion for an empty table.
Useful extra information
The info below often helps, please fill it out if you're able to. :)
What operating system are you using?
What is your DB4S version?
Did you also
The text was updated successfully, but these errors were encountered: