Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app crash #1248

Closed
2 of 14 tasks
isrep opened this issue Dec 1, 2017 · 4 comments
Closed
2 of 14 tasks

app crash #1248

isrep opened this issue Dec 1, 2017 · 4 comments
Assignees
@mgrojo
Labels
crash
Milestone
3.11.0 - Where we...

Comments

@isrep
Copy link

isrep commented Dec 1, 2017

Details for the issue

  1. open DB Browser for SQLite
  2. make sure you are in Execute SQL tab
  3. click "Find text in SQL editor [Ctrl-F]" or press Ctrl-F
  4. app crashes

Thank you for DB Browser for SQLite, it is quite good tool.

Useful extra information

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version: ___ )
  • Linux: ( _distro: Ubuntu v 16.04.3 LTS )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • 3.10.1
  • 3.10.0
  • 3.9.1
  • Other: 882fc8d

I have also:
mgrojo added a commit that referenced this issue Dec 1, 2017
@mgrojo
Avoid crash when starting without a database and activating the find …
5a8d6bb 
…frame

See issue #1248
@mgrojo mgrojo self-assigned this Dec 1, 2017
@mgrojo
Copy link
Member

mgrojo commented Dec 1, 2017

Thanks @isrep. That should be solved in the next nightly build.

I have to remember testing without any database open 😉

@mgrojo mgrojo added the crash label Dec 1, 2017
@isrep
Copy link
Author

isrep commented Dec 2, 2017

While we are at it, there seems to be another crash in 5a8d6bb

  1. open DB Browser for SQLite
  2. make sure you are in Execute SQL tab
  3. click on Save icon and choose "Save SQL file as"
  4. type in some file name into "Select file name" dialog
  5. click Save
  6. app crashes

Thanks again

mgrojo added a commit that referenced this issue Dec 2, 2017
@mgrojo
Prevent crash with "Save SQL file as" when no SQL tab is open
cc61e47 
The same check performed in MainWindow::saveSqlFile() is applied here.

See issue #1248
@mgrojo
Copy link
Member

mgrojo commented Dec 2, 2017

I've applied the same check as in "Save SQL file" for preventing the crash.

A better solution would be to always have an SQL tab open, even when there is no DB open. We let the user open one, so I assume that is not a problem.

Another better solution is to enable the save button (and probably others) only when there is at least one SQL tab.

@isrep
Copy link
Author

isrep commented Dec 2, 2017

Thank you, it does not crash any more.

@isrep isrep closed this as completed Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgrojo mgrojo

Labels
crash
Projects
None yet
Milestone
3.11.0 - Where we take over the world...
Development

No branches or pull requests
3 participants
@justinclift @mgrojo @isrep