Skip to content

Commit

Permalink
dbhub: Attempt to fix the OK button in the Push dialog
Browse files Browse the repository at this point in the history
The OK button in the Remote Push dialog sometimes needed to be clicked
twice in order to work. That's because whenever the Database Name field
loses focus, we would send out a request for the updated branch list.
While processing this request the OK button is effectively disabled by
Qt. This commit aims for an easy fix by changing the request to happen
whenever the text in the Name field changes. This way the timing is a
lot less sensitive. We will need to see however if this introduces other
timing issues for users with slow Internet connections.
  • Loading branch information
MKleusberg committed Jan 13, 2019
1 parent 70d0560 commit a931699
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/RemotePushDialog.ui
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ p, li { white-space: pre-wrap; }
</connection>
<connection>
<sender>editName</sender>
<signal>editingFinished()</signal>
<signal>textChanged(QString)</signal>
<receiver>RemotePushDialog</receiver>
<slot>reloadBranchList()</slot>
<hints>
Expand Down

0 comments on commit a931699

Please sign in to comment.