-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add additional cases for code cells and block comments #10
Conversation
@jnsebgosselin @eafpres @ccordoba12, could you please check if this PR address the missing code cells/block comments syntax? |
So based on what was said in PR spyder-ide/spyder#13885, if I want to test that, I need to clone the repo locally, fetch the branch and install the repo with Is there any risk that I'm going to break my conda installation by doing that? If I recall, Carlos always said that mixing pip and conda is something that is very bad to do. |
@jnsebgosselin, since this package does not depend on Spyder, it shouldn't break anything, so you can install it with pip without any problems, just make sure that is installed with |
Ok excellent. The |
Honestly I'm not sure I'm competent to test this without breaking something locally, so please do not wait on me. |
@eafpres Don't worry, just a quick question should |
I can understand that with the # %% case but this makes less sense to me. However, I’d rather defer to the dev team on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good, thanks @andfoy!
50533d9
to
a4ff010
Compare
@ccordoba12, all the review comments should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment for you @andfoy, then this should be ready.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andfoy!
Hello |
Hi @MCilento93, this fix is available in pyls-spyder v0.2.1, released yesterday |
Mmm I have spyder 4.2.0 o 4.1.5 Can I install or do I need to wait for next spyder release? Sincerely |
You can install it by using conda or pip: # Anaconda (Recommended)
conda install pyls-spyder=0.2.1 -c spyder-ide
# Pip
pip install -U pyls-spyder |
installed, but unfortunately I do not see the comments row (like ### , !!! and so forth) |
Fixes #8
Fixes #9