Followup complex schemas #87
Conversation
|
Regarding the last commit (protobuf), I liked the idea of using the gradle plugin to generate the example java class from a .proto file during the build time, but after fighting with it for quite some time I gave up on it. |
|
Thanks for the follow up @alpreu . I will review this sometime today. I will also see if I can get the protoc going from the plugin (I have had success w/ this recently on an unrelated project). |
There was a problem hiding this comment.
@alpreu another excellent contribution (what else would I expect at this point 😸 ). Thanks for beefing up the tests and docs and also the protobuf schema support.
My only comment is around dep. version management. Once that is addressed we can get this merged. I will check when I come online tomorrow.
As for the proto test file generation via the proto plugin... I did not get a chance to play w/ it. But we should be able to figure it out - not super important though. IIRC the plugin is picky on where the proto lives, and expects it to be in src/[main|test]/protobuf (not 100% sure though).
|
Thanks for the kind words Chris and thanks for drawing my attention to how you manage the dependencies. |
| template.setSchema(kvSchema); | ||
| template.send("keyvalue-topic", new KeyValue<>("Kevin", 3)); |
There was a problem hiding this comment.
@alpreu I forgot to mention this... I see what you did here w/ the clever naming of the message payload to alpha-relate to the feature being tested (avro/avi, json/jason, keyvalue/kevin, protobuf/paul). Seems minor thing but its much better than "foo" or "msg-N" as it relates to test and could help in associating during debugging later etc..
This is the followup PR for #82, adding tests for containing parameters and updating the docs with the supported schema types.