Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AVRO and (inline) KeyValue support for PulsarListener #82

Closed
wants to merge 1 commit into from
Closed

Add AVRO and (inline) KeyValue support for PulsarListener #82

wants to merge 1 commit into from

Conversation

alpreu
Copy link
Contributor

@alpreu alpreu commented Sep 2, 2022

This PR adds support for Avro and KeyValue types in PulsarListener.

Currently, this only supports inline KeyValue types, as we cannot detect which KeyValueEncodingType is used.

Still missing documentation.

@onobc
Copy link
Collaborator

onobc commented Sep 3, 2022

@alpreu,

Thanks for another awesome PR!. Me and @sobychacko reviewed it and it looks good. I know you still wanted to add docs but Soby was going to be working in the same area over the weekend so to avoid the conflict/merge we went ahead and merged it in.

You will notice I added a [polish commit](
Closed via 597bacd). This was aimed at the duplication that already existed in SchemaUtils as well as in the MethodPulsarListenerEndpoint. The only part of the newly added code I changed was to rename from "method"Parameter to "message"Parameter which helped me (coming in fresh to this particular section of the code) to more easily resonate w/ what the code was doing - it made it less generic/abstract to follow along with.

I think we may want to also add a couple of tests to cover List<User> and List<> (not sure if the latter is a valid choice that we allow though.

Closed via c2732c6

@onobc onobc closed this Sep 3, 2022
@alpreu alpreu mentioned this pull request Sep 5, 2022
Merged
onobc pushed a commit that referenced this pull request Sep 6, 2022
Add protobuf schema support (#87)
78efde7 
Additionally the following follow-up items from PR #82 :
* Extend PulsarListenerTests for different Schema types
* Add supported Schema types to docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpreu @onobc