[BUILD] Build improvements #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Each module has its own build.gradle * Functionality moved into plugins in buildSrc/ * Add Spring javaformat * Add release plugins (spring-projects#20) Fixes spring-projects#21
onobc
commented
Aug 6, 2022
| @@ -34,7 +34,7 @@ jobs: | |||
| # GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }} | |||
| # GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_SECRET_ACCESS_KEY }} | |||
| run: | | |||
| ./gradlew clean build --rerun-tasks -PartifactoryUsername="$ARTIFACTORY_USERNAME" -PartifactoryPassword="$ARTIFACTORY_PASSWORD" | |||
| ./gradlew clean build --continue --scan | |||
There was a problem hiding this comment.
Artifactory is not used during PR build
onobc
commented
Aug 6, 2022
| @@ -6,6 +6,8 @@ on: | |||
| - main | |||
| paths-ignore: | |||
| - '.github/**' | |||
| schedule: | |||
| - cron: '0 10 * * *' # Once per day at 10am UTC | |||
There was a problem hiding this comment.
[UNRELATED] Also schedule this to build daily
onobc
commented
Aug 6, 2022
| @@ -44,11 +46,17 @@ jobs: | |||
| # GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }} | |||
| # GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_SECRET_ACCESS_KEY }} | |||
| run: | | |||
| ./gradlew clean build --refresh-dependencies --stacktrace -PartifactoryUsername="$ARTIFACTORY_USERNAME" -PartifactoryPassword="$ARTIFACTORY_PASSWORD" | |||
| ./gradlew clean build --continue -PartifactoryUsername="$ARTIFACTORY_USERNAME" -PartifactoryPassword="$ARTIFACTORY_PASSWORD" | |||
There was a problem hiding this comment.
[UNRELATED] the refresh was left in while debugging something previously
onobc
commented
Aug 6, 2022
| - name: Deploy artifacts | ||
| # env: | ||
| # ORG_GRADLE_PROJECT_signingKey: ${{ secrets.GPG_PRIVATE_KEY }} | ||
| # ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.GPG_PASSPHRASE }} | ||
| # OSSRH_TOKEN_USERNAME: ${{ secrets.OSSRH_S01_TOKEN_USERNAME }} |
There was a problem hiding this comment.
These will be added during #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
NOTES
Next steps
formatetc..