Implement keyed messages #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
requested changes
Jul 28, 2022
There was a problem hiding this comment.
That was fast @alpreu ! Thanks, looks great. I have a few minor comments/suggestions to follow up on. Additionally,
- Please add yourself as
@authoron all modified files. - Do you mind adding some tests cases to the existing PulsarTemplateTests?
Thanks again for the contribution!
spring-pulsar/src/main/java/org/springframework/pulsar/core/PulsarOperations.java
Outdated
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/core/TypedMessageBuilderCustomizer.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Jul 29, 2022
spring-pulsar/src/main/java/org/springframework/pulsar/core/TypedMessageBuilderCustomizer.java
Outdated
Show resolved
Hide resolved
|
Thank you for the feedback, I added the type to the message builder and updated the docs to reflect the changes. If it looks good to you I'll squash and rebase so you can merge :) |
onobc
approved these changes
Aug 2, 2022
|
Looks good @alpreu . I went ahead and squash/rebase/merge. Thanks again for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should implement keyed messaging on the PulsarTemplate (#26).
A detailed description follows.