Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PulsarClient auto-configuration #394

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Apr 25, 2023

What

PulsarClient auto-configuration uses builder rather than raw properties.

Why

  • better user experience when not using SB auto-config
  • type-safety (builder methods vs. string map keys)
  • easier to extend functionality (eg. adding failover client)

@onobc onobc requested a review from sobychacko April 25, 2023 03:29
@onobc onobc force-pushed the cbono-refactor-client-autoconfig branch from 1dbf60d to 81da008 Compare April 27, 2023 00:40
- Apply PulsarProperties to client builder rather than raw
map of Pulsar properties

- Replace PulsarClientFactoryBean with PulsarClientFactory
@onobc onobc force-pushed the cbono-refactor-client-autoconfig branch from 81da008 to b623da6 Compare April 27, 2023 00:49
@onobc onobc modified the milestones: 0.2.1, 1.0.0 Apr 27, 2023
@onobc onobc merged commit dbd1b69 into spring-projects:0.2.x Apr 29, 2023
@onobc onobc deleted the cbono-refactor-client-autoconfig branch April 29, 2023 03:13
onobc added a commit to onobc/spring-pulsar that referenced this pull request Apr 29, 2023
…" from 0.2.x

- Replace PulsarClientFactoryBean with PulsarClientFactory
onobc added a commit that referenced this pull request Apr 29, 2023
)

- Replace PulsarClientFactoryBean with PulsarClientFactory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants