Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide observation API from public API on template and listener #389

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Apr 6, 2023

  • Remove observation registry and convention from constructors on PulsarTemplate and CPLCF
  • Lookup observation registry and convention from app context at start time

As described here

* Remove observation registry and convention from
  constructors on PulsarTemplate and CPLCF

* Lookup observation registry and convention from
  app context at start time
@onobc onobc requested a review from sobychacko April 6, 2023 03:55
@onobc onobc merged commit 9e00c2b into spring-projects:main Apr 11, 2023
@onobc onobc deleted the cbono-obsregistry-lookup branch April 11, 2023 01:35
onobc added a commit to onobc/spring-pulsar that referenced this pull request Apr 14, 2023
…-projects#389)

* Remove observation registry and convention from
  constructors on PulsarTemplate and CPLCF

* Lookup observation registry and convention from
  app context at start time
onobc added a commit that referenced this pull request Apr 19, 2023
* Remove observation registry and convention from
  constructors on PulsarTemplate and CPLCF

* Lookup observation registry and convention from
  app context at start time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant