Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more settings to Consumer in PulsarProperties #223

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Add more settings to Consumer in PulsarProperties #223

merged 1 commit into from
Nov 19, 2022

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented Nov 19, 2022

No description provided.

@cbornet cbornet force-pushed the more-consumer-props branch 3 times, most recently from 043fd0f to 3b2f505 Compare November 19, 2022 03:17
onobc
onobc requested changes Nov 19, 2022
View reviewed changes
Copy link
Collaborator

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbornet looks good. Thanks for getting these config properties all in parity w/ the available client properties. I had one minor test suggestion https://github.com/spring-projects-experimental/spring-pulsar/pull/223/files#r1027036740 - but other than that LGTM.

@cbornet cbornet force-pushed the more-consumer-props branch from dce6502 to 1b8050d Compare November 19, 2022 09:55
@cbornet cbornet requested a review from onobc November 19, 2022 09:57
@onobc onobc merged commit f577e6e into spring-projects:main Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onobc onobc onobc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbornet @onobc