Use SB/SF milestone libs for M1 release #109
Conversation
| @@ -21,10 +21,10 @@ ext { | |||
| protobufJavaVersion = '3.21.5' | |||
| pulsarTestcontainersVersion = '1.17.3' | |||
| pulsarVersion = '2.10.1' | |||
| reactorVersion = '2020.0.17' | |||
| springBootVersion = '3.0.0-SNAPSHOT' | |||
| reactorVersion = '2022.0.0-M4' | |||
There was a problem hiding this comment.
We were really off wrt to the Reactor BOM version (2020?) but all good now. SB and SF both use reactor 3.5.0-M4 and that is contained in 2022-0.0-M4.
| @@ -0,0 +1 @@ | |||
| org.springframework.pulsar.autoconfigure.PulsarAutoConfiguration | |||
There was a problem hiding this comment.
Remove manual import file once we go to SB M5.
Had to revert b188436 (auto-generated auto-config imports file only in SB snapshot)
There was a problem hiding this comment.
Created #110 to go to next milestone and undo these temp changes made in this current PR.
There was a problem hiding this comment.
Created #110 to go to next milestone and undo these temp changes made in this current PR.
| * @author Chris Bono | ||
| */ | ||
| @SpringBootTest(classes = SpringPulsarBootTestApp.class) | ||
| public class SpringPulsarBootAppSanityTests extends AbstractContainerBaseTests { |
There was a problem hiding this comment.
This make sure if the auto-config is off again that we catch it up front. I only caught this because I manually ran the sample apps after making the milestone downgrade.
| @@ -97,7 +98,7 @@ protected void doStart() { | |||
| this.listenerConsumer = new Listener(messageListener); | |||
| setRunning(true); | |||
| this.startLatch = new CountDownLatch(1); | |||
| this.listenerConsumerFuture = consumerExecutor.submitCompletable(this.listenerConsumer); | |||
| this.listenerConsumerFuture = consumerExecutor.submit(this.listenerConsumer); | |||
There was a problem hiding this comment.
This is only in SF SNAPSHOT... will add back in #110
- Made the following TEMPORARY changes to appease downgrading to SB/SF milestones: - Removed `AsynTaskExecutor.submitCompletable` (only in SF snaphot) - Revert b188436 (auto-generated auto-config imports file only in SB snapshot) - Added SpringBootTest sanity test to catch when auto-config is not in place.
onobc
force-pushed
the
cbono-use-milestone-libs
branch
from
e14dbb7 to
c0078b4
Compare
|
LGTM. Merging. |
AsynTaskExecutor.submitCompletable(only in SF snaphot)@alpreu @sobychacko