Introducing experimental consumer error handling #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a Spring specific general mechanism to handle consumer errors regardless of the subscription type. Currently for exclusive and failover subscriptions, Pulsar Java client does not allow the applicaitons to use a DLQ. This feature allows the applications to set a PulsarConsumerErrorHandler that takes a Backoff and PulsarMessageRecoverer to retry and recover the failed message. This is an initial commit for this feature and more changes in this area will follow. Resolves spring-projects#28
onobc
requested changes
Sep 10, 2022
There was a problem hiding this comment.
@sobychacko this is awesome to see! The consumer side is always more challenging/interesting IMO. So as a v0 I abstained from nitpicking docs/tests/style/etc.. (as much as possible for myself 😆 ). The things that fall into that variety are related to understanding the complicated code sections required for this feature. I think they would be beneficial to get in sooner than later - especially the ones in the public facing contract for error handlers.
Looking good!
spring-pulsar/src/main/java/org/springframework/pulsar/listener/PulsarConsumerErrorHandler.java
Outdated
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/listener/PulsarMessageRecoverer.java
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/listener/PulsarConsumerErrorHandler.java
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/listener/PulsarConsumerErrorHandler.java
Outdated
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/listener/PulsarConsumerErrorHandler.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainer.java
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/listener/PulsarConsumerErrorHandler.java
Outdated
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/listener/PulsarConsumerErrorHandler.java
Outdated
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/listener/PulsarConsumerErrorHandler.java
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/listener/PulsarMessageRecoverer.java
Outdated
Show resolved
Hide resolved
This was referenced Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a Spring specific general mechanism to handle consumer errors regardless of the subscription type. Currently for exclusive and failover subscriptions, Pulsar Java client does not allow the applicaitons to use a DLQ. This feature allows the applications to set a PulsarConsumerErrorHandler that takes a Backoff and PulsarMessageRecoverer to retry and recover the failed message.
This is an initial commit for this feature and more changes in this area will follow.
Resolves #28