Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owners search has been case insensitive #134

Merged
merged 1 commit into from
Mar 6, 2016

Conversation

broccolinisoup
Copy link
Contributor

It is not an SQL standard. It works well with HSQLDB. However, mysql VARCHAR already allows case insensitive search. I mean, developers who use mysql for petclinic db, they already do the case insensitive searches. It is for just HSQLDB. So, we do not need to make any change on mysql/initDB.sql. I tested case insensitive search with both HSQLDB and MYSQL. Everything looks fine.

@arey
Copy link
Contributor

arey commented Feb 25, 2016

Do yo know if the VARCHAR_IGNORECASE type belongs to the SQL standard?
And have you test it on MySQL (mysql/initDB.sql)?

@arey arey self-assigned this Feb 25, 2016
@broccolinisoup
Copy link
Contributor Author

Hello Arey,
Probably you are so busy I understand but the ticket is still waiting. Could you please check it? @arey

@arey
Copy link
Contributor

arey commented Mar 5, 2016

This ticket is still waiting because if your change is working on any RDBMS?

@broccolinisoup
Copy link
Contributor Author

Hello @arey ,
I wrote a comment but probably you haven't seen it. It is on the top.
It was "It is not an SQL standard. It works well with HSQLDB. However, mysql VARCHAR already allows case insensitive search. I mean, developers who use mysql for petclinic db, they already do the case insensitive searches. It is for just HSQLDB. So, we do not need to make any change on mysql/initDB.sql. I tested case insensitive search with both HSQLDB and MYSQL. Everything looks fine."

@arey
Copy link
Contributor

arey commented Mar 6, 2016

I'm sorry @broccolinisoup but I didn't see your first comment. In this condition, we can accept your change. Thanks you

@arey arey closed this Mar 6, 2016
@arey arey reopened this Mar 6, 2016
arey added a commit that referenced this pull request Mar 6, 2016
owners search has been case insensitive
@arey arey merged commit 9ad12d3 into spring-projects:master Mar 6, 2016
@broccolinisoup
Copy link
Contributor Author

No worries @arey Thank you for your time!

attil-io added a commit to attil-io/spring-petclinic that referenced this pull request Jun 17, 2016
owners search has been case insensitive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants